test: adapt existing suites to unconditional core, drop dead detector tests

This commit is contained in:
2026-09-30 03:08:13 +03:00
parent 7dc2ec79d1
commit 8172ba2541
6 changed files with 103 additions and 320 deletions
+9 -184
View File
@@ -7,7 +7,6 @@ work together correctly.
"""
import numpy as np
import pytest
from beta_spectrum import BetaSpectrum, SpectrumConfig
@@ -61,13 +60,12 @@ class TestBetaSpectrumToggles:
"""Test that component toggling works correctly."""
def test_all_disabled(self):
"""With all corrections disabled, only phase space remains — still valid output."""
"""With all corrections disabled, the core remains — still valid output."""
config = SpectrumConfig(
Z_parent=19,
Z_daughter=20,
A_number=40,
endpoint_MeV=2.5,
use_fermi=False,
use_screening=False,
use_finite_size=False,
use_charge_dist=False,
@@ -82,14 +80,14 @@ class TestBetaSpectrumToggles:
assert len(values) > 0, "Should return non-empty array"
assert np.all(np.isfinite(values)), "All values must be finite"
def test_fermi_only(self):
"""With only fermi function enabled: should give F₀(Z,W) — not just phase space."""
def test_core_equals_phase_space_times_fermi(self):
"""Core components are unconditional: with corrections disabled the
spectrum equals phase space × Fermi function exactly."""
config_minimal = SpectrumConfig(
Z_parent=19,
Z_daughter=20,
A_number=40,
endpoint_MeV=2.5,
use_phase_space=False,
use_screening=False,
use_finite_size=False,
use_charge_dist=False,
@@ -101,8 +99,11 @@ class TestBetaSpectrumToggles:
W, _ = spectrum.get_energy_grid(config_minimal)
values = spectrum(W)
# Fermi function alone is ~1 for Z=20 at mid-energy
assert np.all(np.isfinite(values)), "Fermi-only output must be finite"
components = spectrum.calculate_components(W)
assert set(components.keys()) == {"PhaseSpace", "Fermi"}
expected = components["PhaseSpace"] * components["Fermi"]
assert np.allclose(values, expected, rtol=1e-10)
assert np.all(np.isfinite(values)), "Core-only output must be finite"
class TestBetaSpectrumComponentExtraction:
@@ -158,179 +159,3 @@ class TestBetaSpectrumRealisticConfig:
assert np.all(np.isfinite(values)), "C-14 must not produce NaN/inf"
# Phase space should peak in the bulk for low-Q decay
assert np.any(values > 0), "Should have non-zero spectrum values"
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
class TestDeclarativeDetectorResponse:
"""Test declarative detector response workflow via SpectrumConfig."""
def test_create_detector_from_config(self):
"""SpectrumConfig detector params should create valid DetectorResponse."""
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_model="gaussian",
detector_sigma_a_keV=1.0,
detector_n_channels=512,
)
detector = BetaSpectrum.create_detector_from_config(config)
from beta_spectrum.components.detector_response import DetectorResponse
assert isinstance(detector, DetectorResponse)
assert detector.n_channels == 512
assert detector._mode == "analytical"
assert detector.model == "gaussian"
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_detector_sigma_conversion(self):
"""Sigma in keV should be correctly converted to m_e units."""
from beta_spectrum.utils import T_to_W
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_sigma_a_keV=1.0,
detector_fano_factor=0.0,
)
detector = BetaSpectrum.create_detector_from_config(config)
# 1.0 keV = 1.0/511.0 m_e ≈ 0.00196
expected_sigma = 1.0 / 0.510998950
sigma_at_endpoint = detector._resolution_sigma(T_to_W(0.294))
assert np.isclose(sigma_at_endpoint, expected_sigma, rtol=0.01)
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_convolve_detector_single_call(self):
"""convolve_detector() should work in a single call with config params."""
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_model="gaussian",
detector_sigma_a_keV=1.0,
detector_n_channels=512,
detector_fano_factor=0.0,
)
spectrum = BetaSpectrum.from_config(config)
W, _ = spectrum.get_energy_grid(config)
convolved = spectrum.convolve_detector(config, W=W)
assert convolved.shape == (512,)
assert np.all(convolved >= 0), "Convolved spectrum should be non-negative"
assert np.sum(convolved) > 0, "Convolved spectrum should have non-zero area"
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_convolve_detector_with_tail(self):
"""Convolution with tail model should produce low-energy tailing."""
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_model="gaussian_tail",
detector_sigma_a_keV=1.0,
detector_tail_fraction=0.2,
detector_tau_keV=5.0,
detector_n_channels=512,
detector_fano_factor=0.0,
)
spectrum = BetaSpectrum.from_config(config)
W, _ = spectrum.get_energy_grid(config)
convolved = spectrum.convolve_detector(config, W=W)
assert convolved.shape == (512,)
assert np.all(convolved >= 0)
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_analyzer_convolved_from_config(self):
"""BetaSpectrumAnalyzer should use config detector params automatically."""
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
use_detector_response=True,
detector_model="gaussian",
detector_sigma_a_keV=1.0,
detector_n_channels=256,
detector_fano_factor=0.0,
)
spectrum = BetaSpectrum.from_config(config)
from beta_spectrum import BetaSpectrumAnalyzer
analyzer = BetaSpectrumAnalyzer(spectrum, config)
detector = BetaSpectrum.create_detector_from_config(config)
convolved = analyzer.convolved_spectrum(detector, normalize=True)
assert convolved.shape == (256,)
# Normalized spectrum should integrate to ~1 over channel energies
integral = np.trapezoid(convolved, detector.channel_energies)
assert np.isclose(integral, 1.0, rtol=0.05), (
f"Integral should be ~1.0, got {integral}"
)
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_detector_range_extends_to_endpoint(self):
"""Detector channel range should extend to cover spectrum endpoint."""
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_channel_energy_range=(0.0, 0.2), # Less than endpoint
detector_n_channels=256,
detector_fano_factor=0.0,
)
detector = BetaSpectrum.create_detector_from_config(config)
# Range should extend beyond endpoint in m_e units
from beta_spectrum.utils import T_to_W
W0 = T_to_W(0.294)
assert detector.channel_energies[-1] >= W0, (
f"Detector range {detector.channel_energies[-1]:.4f} should cover "
f"endpoint {W0:.4f}"
)
@pytest.mark.skip(reason="DetectorResponse not yet implemented")
def test_different_detector_models(self):
"""All detector models should produce valid convolved spectra."""
models = ["gaussian", "gaussian_tail", "tikhonov"]
for model in models:
config = SpectrumConfig(
Z_parent=43,
Z_daughter=44,
A_number=99,
endpoint_MeV=0.294,
detector_model=model,
detector_sigma_a_keV=1.0,
detector_n_channels=256,
detector_fano_factor=0.0,
)
if model == "gaussian_tail":
config.detector_tail_fraction = 0.1
config.detector_tau_keV = 5.0
spectrum = BetaSpectrum.from_config(config)
W, _ = spectrum.get_energy_grid(config)
convolved = spectrum.convolve_detector(config, W=W)
assert convolved.shape == (256,)
assert np.all(convolved >= 0), f"Model {model} produced negative values"